Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix bluetooth adapters with missing firmware patch files not being discovered #81926

Merged
merged 1 commit into from
Nov 10, 2022
Merged

Fix bluetooth adapters with missing firmware patch files not being discovered #81926

merged 1 commit into from
Nov 10, 2022

Conversation

bdraco
Copy link
Member

@bdraco bdraco commented Nov 10, 2022 •
edited
Loading

Proposed change

If the linux kernel is configured with CONFIG_FW_LOADER_USER_HELPER_FALLBACK (which is currently set to y for the Odroid n2+ with HAOS) there is a 120s delay registered the USB bluetooth adapter on the bus which prevented discovery of the adapter because it was not there in time between when we get the signal for a new USB device to the time we ask Dbus about which adapters are available

This makes all it possible to discover the broadcom adapters without a restart of core

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

@bdraco
Ensure bluetooth adapters with missing firmware patch files can be di…
ca9f81f 
…scovered

If the linux kernel is configured with CONFIG_FW_LOADER_USER_HELPER_FALLBACK
(which is currently set to y for the Odroid n2+ with HAOS) there is a 120s
delay registered the USB bluetooth adapter on the bus which prevented
discovery of the adapter because it was not there in time between when
we get the signal for a new USB device to the time we ask Dbus about
which adapters are available

This makes all it possible to discover the broadcom adapters without
a restart of core
@bdraco bdraco added this to the 2022.11.3 milestone Nov 10, 2022
@bdraco bdraco mentioned this pull request Nov 10, 2022
Merged
8 tasks
@bdraco bdraco changed the title Ensure bluetooth adapters with missing firmware patch files can be discovered Fix bluetooth adapters with missing firmware patch files not being discovered Nov 10, 2022
@bdraco bdraco mentioned this pull request Nov 10, 2022
Open
bachya
bachya approved these changes Nov 10, 2022
View reviewed changes
Copy link
Contributor

@bachya bachya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool!

@bdraco
Copy link
Member Author

bdraco commented Nov 10, 2022

Thanks

@bdraco bdraco merged commit 78180b2 into home-assistant:dev Nov 10, 2022
@bdraco bdraco deleted the bluetooth_firmware_fallback branch November 10, 2022 20:14
@github-actions github-actions bot locked and limited conversation to collaborators Nov 11, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@bachya bachya bachya approved these changes

Assignees
No one assigned
Labels
bugfix by-code-owner cherry-picked cla-signed has-tests integration: bluetooth Quality Scale: internal
Projects
None yet
Milestone
2022.11.3
Development

Successfully merging this pull request may close these issues.
3 participants
@bdraco @bachya @frenck